Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lambda Layer Update: OTel Python 1.12.0 & 0.33b0 #242

Merged
merged 5 commits into from
Aug 31, 2022

Conversation

vasireddy99
Copy link
Contributor

@vasireddy99 vasireddy99 commented May 19, 2022

This PR updates the OTel Python Core dependencies to 1.12.0 and OTel Python Contrib dependencies to 0.33b0

Adding detail for PR build;
Executed the command tox in local and can verify both python3.8 , python3.9 are succeeded

image

Resolves :

@vasireddy99 vasireddy99 marked this pull request as draft May 19, 2022 22:19
@vasireddy99 vasireddy99 changed the title Lambda Layer Update: OTel Python 1.12.0cr1 & 0.31b0 Lambda Layer Update: OTel Python 1.12.0rc1 & 0.31b0 May 20, 2022
@vasireddy99 vasireddy99 marked this pull request as ready for review May 20, 2022 18:53
@vasireddy99 vasireddy99 marked this pull request as draft May 20, 2022 19:15
@NathanielRN
Copy link
Contributor

We spoke offline and decided we do not want to jump the gun and release Python Lambda layers while the OTel Python SIG has them in pre-release. That is the case for 1.12.0rc1:

image

@vasireddy99 was able to pass the tests (and avoid the problem where conflicting versions like 1.11.0 are installed), by updating the CORE_REPO_SHA environment variable to point to the repo at the pre-release itself. Otherwise, it installs opentelemetry-test-utils at the specified commit and that package in turns pulls the latest stabe release of opentelemetry-api. Which is 1.11.0 right now.

We shouldn't release pre-releases because they are still being tested for bugs. For example consider this open issue with the latest 1.12.0rc1 release candidate 🙂

open-telemetry/opentelemetry-python#2716

@suqi
Copy link

suqi commented Aug 24, 2022

Hello @NathanielRN @vasireddy99 , please help check again, OTel Python has released v1.12.0 officially several days ago.
https://github.com/open-telemetry/opentelemetry-python/releases/tag/v1.12.0

And if it cannot get upgrade, now my OTel lambda layer is reporting error

TracerProvider was missing force_flush method. This is necessary in case of a Lambda freeze and would exist in the OTel SDK implementation.

More detailed error info:

image

Thank you Team, have a good day!

@vasireddy99
Copy link
Contributor Author

This PR will be updated to use 1.12.0 soon.

@vasireddy99 vasireddy99 force-pushed the updatepy branch 4 times, most recently from 2bc15f6 to 4fac5aa Compare August 25, 2022 05:20
@vasireddy99 vasireddy99 changed the title Lambda Layer Update: OTel Python 1.12.0rc1 & 0.31b0 Lambda Layer Update: OTel Python 1.12.0 & 0.33b0 Aug 25, 2022
@vasireddy99 vasireddy99 marked this pull request as ready for review August 25, 2022 05:24
@@ -9,14 +9,16 @@ on:

env:
AWS_REGION: us-east-1
#copied the core repo sha from here:https://github.com/open-telemetry/opentelemetry-python-contrib/blob/main/.github/workflows/test.yml#L9
CORE_REPO_SHA: ece57231cde5bb5656775a62f027cab0b1c76fce
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this env variable would be necessary to test against the specific commit other than main and is in a format the tests to follow the format of upstream


jobs:
PR-Python:
runs-on: ubuntu-latest

strategy:
matrix:
python: [3.8, 3.9]
python: ['3.8', '3.9']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to do this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The usage of quotes is recommended by setup-python in gh actions. It would cause error when suppose a version 3.10 has to be used.

@vasireddy99 vasireddy99 marked this pull request as draft August 30, 2022 17:11
@vasireddy99 vasireddy99 marked this pull request as ready for review August 31, 2022 06:18
@vasireddy99 vasireddy99 marked this pull request as draft August 31, 2022 18:52
@vasireddy99 vasireddy99 marked this pull request as ready for review August 31, 2022 19:51
@NathanielRN NathanielRN merged commit fc372a2 into open-telemetry:main Aug 31, 2022
@vasireddy99 vasireddy99 deleted the updatepy branch September 6, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants