-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lambda Layer Update: OTel Python 1.12.0 & 0.33b0 #242
Conversation
We spoke offline and decided we do not want to jump the gun and release Python Lambda layers while the OTel Python SIG has them in pre-release. That is the case for @vasireddy99 was able to pass the tests (and avoid the problem where conflicting versions like We shouldn't release pre-releases because they are still being tested for bugs. For example consider this open issue with the latest |
Hello @NathanielRN @vasireddy99 , please help check again, OTel Python has released v1.12.0 officially several days ago. And if it cannot get upgrade, now my OTel lambda layer is reporting error
More detailed error info: Thank you Team, have a good day! |
This PR will be updated to use |
2bc15f6
to
4fac5aa
Compare
@@ -9,14 +9,16 @@ on: | |||
|
|||
env: | |||
AWS_REGION: us-east-1 | |||
#copied the core repo sha from here:https://github.com/open-telemetry/opentelemetry-python-contrib/blob/main/.github/workflows/test.yml#L9 | |||
CORE_REPO_SHA: ece57231cde5bb5656775a62f027cab0b1c76fce |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this env variable would be necessary to test against the specific commit other than main
and is in a format the tests to follow the format of upstream
|
||
jobs: | ||
PR-Python: | ||
runs-on: ubuntu-latest | ||
|
||
strategy: | ||
matrix: | ||
python: [3.8, 3.9] | ||
python: ['3.8', '3.9'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to do this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The usage of quotes is recommended by setup-python in gh actions. It would cause error when suppose a version 3.10
has to be used.
This PR updates the OTel Python Core dependencies to 1.12.0 and OTel Python Contrib dependencies to 0.33b0
Adding detail for PR build;
Executed the command
tox
in local and can verify bothpython3.8
,python3.9
are succeededResolves :
`