Use 'databind' dependency not 'core' in Lambda env #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanielRN
force-pushed
the
add-databind-dependency-not-core
branch
from
5af0d66 to
7de85d0
Compare
anuraaga
reviewed
Feb 1, 2022
java/layer-wrapper/build.gradle.kts
Outdated
| // See here: https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/5284 | ||
| runtimeOnly("com.fasterxml.jackson.core:jackson-core") | ||
| // See here: https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/5285 | ||
| implementation("com.fasterxml.jackson.core:jackson-databind") |
There was a problem hiding this comment.
We don't compile any code here so can use runtimeOnly
vasireddy99
approved these changes
Feb 1, 2022
NathanielRN
force-pushed
the
add-databind-dependency-not-core
branch
from
7de85d0 to
af13d98
Compare
vasireddy99
approved these changes
Feb 1, 2022
anuraaga
approved these changes
Feb 1, 2022
wangzlei
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #211, we did need to bring in a new dependency, but we brought in the wrong one. We need
jackson-databindnotjackson-core.We also useimplementationinstead ofruntimeOnlybecause we want it to be used both when compiling and when published in the POM for downstream, but we don't need to leak it to other modules. We just want it in this one so we have it for BOTH compile time & run time.We can use
runtimeOnlybecause we don't compile any code.