Support architectures across all sample apps #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanielRN
force-pushed
the
support-architectures-in-all-sample-apps
branch
3 times, most recently
from
8113dae to
04ff297
Compare
NathanielRN
force-pushed
the
support-architectures-in-all-sample-apps
branch
from
04ff297 to
f0c1998
Compare
|
Because the main-build workflow on my repo in the aws-otel-lambda downstream mostly works, this PR is ready to merge! The reason we say mostly is because of an issue we are tracking internally where X-Ray spans appear out of order on the console at inconsistent times for the .NET, NodeJS, Python, and Go Lambda Functions. (Java has never failed in this regard). |
wangzlei
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
architecturesas an input variable for every sample app created using terraform.