Use Makefile operator to get GOARCH default #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanielRN
force-pushed
the
use-operator-to-provide-GOARCH-default
branch
from
0854d7f to
e3531b7
Compare
* Fix bash syntax default for ENV var by using Makefile var syntax * Modify the Collector CI test to validate the binary architecture
NathanielRN
force-pushed
the
use-operator-to-provide-GOARCH-default
branch
from
e3531b7 to
ba6fe15
Compare
wangzlei
approved these changes
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I completely forgot to change this line in #181 which is crucial so that the Makefile will read the
GOARCHenvironment variable if one is specified.This PR fixes that and also adds a PR time workflow to test that the collector can be built correctly for multiple architectures.