Use Go 1.17 because Collector cannot be built without it #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanielRN
force-pushed
the
test-branch-for-ci
branch
13 times, most recently
from
40ef854 to
baed661
Compare
NathanielRN
changed the title
NathanielRN
force-pushed
the
test-branch-for-ci
branch
7 times, most recently
from
a3007dc to
5b2c852
Compare
* The recent v0.39.0 collector introduced a change that required go 1.17 * We can't download go 1.17 in the Docker Container used by SAM * We build the collector outside the Docker Container and just copy over later
NathanielRN
force-pushed
the
test-branch-for-ci
branch
from
5b2c852 to
f76ade0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Build collector before we use SAM Docker Container.