Lambda Layer Update - OTel Python 1.7.1 & 0.26b1 #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanielRN
force-pushed
the
use-upstream-python-lambda-instrumentation
branch
from
7745fd0 to
6ddfd65
Compare
NathanielRN
commented
Nov 16, 2021
|
|
||
| test_env_patch.stop() | ||
|
|
||
| def test_using_custom_extractor(self): |
There was a problem hiding this comment.
This test is already upstream so we don't need to duplicate it here.
NathanielRN
force-pushed
the
use-upstream-python-lambda-instrumentation
branch
3 times, most recently
from
107b9a6 to
b5e89ae
Compare
NathanielRN
force-pushed
the
use-upstream-python-lambda-instrumentation
branch
from
b5e89ae to
e3a7880
Compare
wangzlei
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because OTel Python has released version 1.7.1 at open-telemetry/opentelemetry-python@281c97b, we are able to use the upstreamed code for the AWS Lambda Instrumentation instead of having a copy of it here in this repo.
We also included some small nit updates in passing to the build files + the CI files.
Built the layer locally and tested on Lambda, confirmed that OTel Python is still initialized correctly and traces appear.