Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade common OTEL packages used by other OTEL packages to prevent having multiple versions of the same OTEL packages #1562

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

serkan-ozal
Copy link
Contributor

@serkan-ozal serkan-ozal commented Oct 22, 2024

Without this fix, it is very likely to hit the package size limit which puts 250 MB limit (unzipped) for the contents of a deployment package, including layers and custom runtimes.

This fix also helps to reduce the coldstart delay by reducing the deployment artifact size.

Compressed Size

Before fix (v0.10.0): 38.5 MB
After fix: 8.5 MB

78% package size improvement.

Uncompressed Size (On Disk)

Before fix (v0.10.0): 202.1 MB
After fix: 42.6 MB

79% package size improvement.

@serkan-ozal serkan-ozal requested a review from a team as a code owner October 22, 2024 08:50
…aving multiple versions of the same OTEL packages
@serkan-ozal serkan-ozal force-pushed the fix-huge-artifact-size branch from 0c665ee to 000525c Compare October 22, 2024 11:11
Copy link
Contributor

@pragmaticivan pragmaticivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@tylerbenson tylerbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we need a build assertion somewhere to verify this doesn't happen again?

@serkan-ozal
Copy link
Contributor Author

Maybe we need a build assertion somewhere to verify this doesn't happen again?

@tylerbenson yes, right. I think, at least we can put a hard-coded compressed and un-compressed size limit (for ex. 10 MB compressed size limit) check step in the Node.js layer release action after building but before publishing the layer.

@tylerbenson tylerbenson merged commit 155747d into open-telemetry:main Oct 23, 2024
10 checks passed
@tylerbenson tylerbenson added the javascript Pull requests that update Javascript code label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants