Add back dependency on instrumentation pkg because of sdk pkg updates #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanielRN
requested review from
anuraaga,
codeboten and
wangzlei
as code owners
anuraaga
approved these changes
Oct 19, 2021
NathanielRN
deleted the
add-back-opentelemetry-instrumentation-pkg-dep
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #148 we had removed our dependency on
opentelemetry-instrumentationbecause theopentelemetry-sdkpackage depended on it.Recently, upstream moved removed
opentelemetry-sdk's dependency on it: open-telemetry/opentelemetry-python-contrib#738This PR is just anticipating that change for the next Lambda release so that we don't have any surprises about missing imports.
cc @willarmiros