Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct otelcol version #1543

Merged
merged 1 commit into from
Oct 3, 2024
Merged

correct otelcol version #1543

merged 1 commit into from
Oct 3, 2024

Conversation

nslaughter
Copy link
Contributor

@nslaughter nslaughter commented Oct 2, 2024

This corrects the otelcol-version in the build.

Validate by putting garbage in the VERSION file. Then run make build and look at -X main.Version=v0.109.0. Without the change it said -X main.Version=UNSET. Then look at the VERSION file and see it is also updated.

Closes #1457

@nslaughter nslaughter requested a review from a team as a code owner October 2, 2024 20:52
@tylerbenson tylerbenson merged commit 39dc9fd into main Oct 3, 2024
13 checks passed
@tylerbenson tylerbenson deleted the correct-version branch October 3, 2024 15:31
@tylerbenson tylerbenson added the go Pull requests that update Go code label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

collector -v is UNSET in 0.9.0
3 participants