Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Generate function and extension logs via Telemetry API receiver #1347
Feature: Generate function and extension logs via Telemetry API receiver #1347
Changes from 11 commits
bd5dd05
63558a8
1ae4fdd
0f74cbe
0c54292
dd2e317
13a99af
4ff5876
730cfc9
999a7ce
1190cb5
165cdda
26a3c68
16f92d1
2575871
a297035
2d33076
cdea000
166628a
2e03ffe
3b7cda5
1bc05fb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would want more data protection in this file than I see in the top-level variable for
receivers
, but it looks like the code doesn't read fromreceivers
. As I traced my steps through this code, I started thinking we wouldn't get a benefit from the call toGetOrAdd
receivers. What if we changed that to the following?And if that works we don't have to rely on copying
internal/sharedcomponent
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and actually this is a bit fragile. this means that you cannot use this receiver in lets say, more than one pipeline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking to reuse the http server.
internal/sharedcomponent
can help to reuse the http server by looking up the receiver using cfg as a key.I was assuming we could have configuration for
telemetryapi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
sharedcomponent
could play a role so as to reuse http server and to support multiple instances of telemetry api receiver.Can you take a look to the updated change and let me know your feedback? Thanks!