-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add secretsmanager confmap provider #1324
Add secretsmanager confmap provider #1324
Conversation
I initially thought that it would be possible to use environment variables and some integration between lambda and secrets manager, but it seems that it is not possible and maybe it does not make sense because env vars values don't dynamically update across invocations, having said that I think it makes sense to include this confmap provider here. Not a blocker for this pr, but one thing that I wanted to understand is how much these confmap providers that require fetching the configuration from a remote place add to the cold start time. LGTM! thanks! |
Resolved conflicts. |
@tylerbenson can we get this pull request merged? |
@hkarn-godaddy sorry. One last rebase please and I'll get it merged. |
PR updated. |
This PR adds secretsmanagerprovider confmap provider from opentelemetry-collector-contrib repo.