Add java wrapper layer build #1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This approach contains a few arbitrary decisions. - I chose to tie it to the same release job as java as they will likely always have changes together (sdk version). - No independent tagging for the wrapper release. - The underlying reported version for the wrapper layer will report `--`. (Since the wrapper won't have a separate release page, I think this is ok.)
I'm not sure if this will always be true. The java agent also includes instrumentation for a bunch of libraries no while the wrapper will only contain aws-lambda instrumentation + Otel SDK. Having said that I think it is fine to release them together for now. |
rapphil
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This approach contains a few arbitrary decisions.
--. (Since the wrapper won't have a separate release page, I think this is ok.)