Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: merge opentelemetry-base to opentelemetry-core #991

Merged
merged 2 commits into from
Apr 29, 2020

Conversation

legendecas
Copy link
Member

Which problem is this PR solving?

  • Fixes merge base into api #968
  • They act as a very similar role in the SDK.
  • ExportResult is a type used in Exporter API yet has to be imported from an additional package to @opentelemetry/api and @opentelemetry/core.

Short description of the changes

  • merged @opentelemetry/base to @opentelemetry/core

@mayurkale22
Copy link
Member

Please fix the build.

@codecov-io
Copy link

codecov-io commented Apr 29, 2020

Codecov Report

Merging #991 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #991      +/-   ##
==========================================
+ Coverage   94.90%   94.92%   +0.02%     
==========================================
  Files         212      212              
  Lines        8676     8671       -5     
  Branches      791      792       +1     
==========================================
- Hits         8234     8231       -3     
+ Misses        442      440       -2     
Impacted Files Coverage Δ
packages/opentelemetry-core/src/ExportResult.ts 100.00% <ø> (ø)
...s/opentelemetry-core/src/platform/node/sdk-info.ts 100.00% <ø> (ø)
...s/opentelemetry-metrics/src/export/NoopExporter.ts 33.33% <ø> (ø)
packages/opentelemetry-metrics/src/export/types.ts 100.00% <ø> (ø)
...ages/opentelemetry-core/src/platform/node/index.ts 100.00% <100.00%> (ø)
...emetry-exporter-collector/src/CollectorExporter.ts 90.24% <100.00%> (-0.24%) ⬇️
.../opentelemetry-exporter-collector/src/transform.ts 95.71% <100.00%> (-0.07%) ⬇️
...ckages/opentelemetry-exporter-jaeger/src/jaeger.ts 89.79% <100.00%> (-0.21%) ⬇️
.../opentelemetry-exporter-jaeger/test/jaeger.test.ts 100.00% <100.00%> (ø)
...pentelemetry-exporter-prometheus/src/prometheus.ts 92.00% <100.00%> (-0.08%) ⬇️
... and 13 more

They act a very similar role in the SDK.
@legendecas
Copy link
Member Author

@mayurkale22 Test fixed :)

Copy link
Member

@vmarchaud vmarchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mayurkale22 mayurkale22 merged commit 23677a1 into open-telemetry:master Apr 29, 2020
@legendecas legendecas deleted the base branch April 30, 2020 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

merge base into api
5 participants