feat: metric observer #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obecny
requested review from
bg451,
dyladan,
markwolff,
mayurkale22,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
obecny
added
the
size/L
Codecov Report
@@ Coverage Diff @@
## master #828 +/- ##
=========================================
+ Coverage 94.19% 94.2% +0.01%
=========================================
Files 249 250 +1
Lines 10857 10948 +91
Branches 1058 1058
=========================================
+ Hits 10227 10314 +87
- Misses 630 634 +4
|
mayurkale22
reviewed
Mar 3, 2020
mayurkale22
reviewed
Mar 4, 2020
packages/opentelemetry-exporter-prometheus/test/prometheus.test.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-exporter-prometheus/test/prometheus.test.ts
Outdated
Show resolved
Hide resolved
dyladan
reviewed
Mar 4, 2020
| "description": "Example of using @opentelemetry/metrics", | ||
| "main": "index.js", | ||
| "scripts": { | ||
| "start:observer": "node metrics/observer.js" |
There was a problem hiding this comment.
Some reason this is start:observer instead of just start?
There was a problem hiding this comment.
I have created metrics example to be a place for other metrics too, so next step when working on documentation and examples should be to add start:counter, start:measure
mayurkale22
approved these changes
Mar 4, 2020
vmarchaud
approved these changes
Mar 5, 2020
dyladan
approved these changes
Mar 5, 2020
dyladan
pushed a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
* feat: metric observer * chore: update after review * chore: reviews Co-authored-by: Mayur Kale <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes