-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add composite propagator #821
Merged
dyladan
merged 10 commits into
open-telemetry:master
from
dynatrace-oss-contrib:composite-propagator
Mar 4, 2020
Merged
feat: add composite propagator #821
dyladan
merged 10 commits into
open-telemetry:master
from
dynatrace-oss-contrib:composite-propagator
Mar 4, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyladan
requested review from
bg451,
markwolff,
mayurkale22,
obecny,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
February 28, 2020 17:45
Codecov Report
@@ Coverage Diff @@
## master #821 +/- ##
==========================================
- Coverage 94.13% 92.68% -1.45%
==========================================
Files 249 247 -2
Lines 10751 10997 +246
Branches 1028 1071 +43
==========================================
+ Hits 10120 10193 +73
- Misses 631 804 +173
|
mayurkale22
reviewed
Feb 28, 2020
packages/opentelemetry-core/src/context/propagation/composite.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-core/src/context/propagation/composite.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-core/src/context/propagation/composite.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-core/src/context/propagation/composite.ts
Outdated
Show resolved
Hide resolved
Please fix the build |
vmarchaud
approved these changes
Mar 1, 2020
Flarna
reviewed
Mar 2, 2020
packages/opentelemetry-core/src/context/propagation/composite.ts
Outdated
Show resolved
Hide resolved
mayurkale22
approved these changes
Mar 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
packages/opentelemetry-core/src/context/propagation/composite.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-core/src/context/propagation/composite.ts
Outdated
Show resolved
Hide resolved
OlivierAlbertini
approved these changes
Mar 3, 2020
Co-Authored-By: Olivier Albertini <[email protected]>
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?