chore: clear Prometheus todo and rename ReadableMetric -> MetricRecord #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurkale22
requested review from
bg451,
dyladan,
markwolff,
obecny,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
dyladan
approved these changes
Feb 20, 2020
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
* feat: implement instrumentation for tedious * feat: collect procedure and statement counts + clean up after tests * test: spin up MSSQL DB for the tests * test: add mssql service to GHA * fix: reference the correct vars * fix: add nyc to test command * fix: use older version of mocha * fix: ignore tedious on node@8 - it's not supported * feat: remove listeners when the span ends * feat: track database changes * feat: support <11.0.9 * feat: support <11.0.8 * feat: support <8.3.0 * feat: support <7 * feat: support >=1.10.0 <4 * style: lint and types * chore: remove the "opentelemetry-" prefix * refactor: namespace api functionality * feat: instrument bulk loads * feat: support bulkLoad on old versions * docs: fix the supported versions range * fix: rename --include-filtered-dependencies * fix: use localhost for the mssql service * fix: map the port properly * chore: add me as the component owner * docs: add comments about cardinality in `getSpanName` * fix: short-circuit in the case of unexpected input * feat: give current-database symbol more descriptive name * fix: fix types for arguments * fix: ensure setDatabase listener is only ever added once * docs: add tedious to the main README * style: fix lint * feat: log an error if request.callback is not a function * docs: touch up the package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.