-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove getDefaultBound and setCallback from Metric API #793
Merged
mayurkale22
merged 2 commits into
open-telemetry:master
from
mayurkale22:remove_deprecated_methods
Feb 20, 2020
Merged
remove getDefaultBound and setCallback from Metric API #793
mayurkale22
merged 2 commits into
open-telemetry:master
from
mayurkale22:remove_deprecated_methods
Feb 20, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurkale22
requested review from
bg451,
dyladan,
markwolff,
obecny,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
February 19, 2020 18:50
dyladan
approved these changes
Feb 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool they're unimplemented anyways
OlivierAlbertini
approved these changes
Feb 20, 2020
obecny
approved these changes
Feb 20, 2020
Codecov Report
@@ Coverage Diff @@
## master #793 +/- ##
==========================================
- Coverage 94.48% 94.34% -0.15%
==========================================
Files 239 246 +7
Lines 10468 10809 +341
Branches 998 1034 +36
==========================================
+ Hits 9891 10198 +307
- Misses 577 611 +34
|
dyladan
added
the
Merge:LGTM
This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
label
Feb 20, 2020
dyladan
pushed a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Merge:LGTM
This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
getDefaultBound
andsetCallback
are non-compliant methods with specifications./cc @dyladan