Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove getDefaultBound and setCallback from Metric API #793

Merged

Conversation

mayurkale22
Copy link
Member

Which problem is this PR solving?

  • I think getDefaultBound and setCallback are non-compliant methods with specifications.

/cc @dyladan

Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool they're unimplemented anyways

@codecov-io
Copy link

Codecov Report

Merging #793 into master will decrease coverage by 0.14%.
The diff coverage is 98.71%.

@@            Coverage Diff             @@
##           master     #793      +/-   ##
==========================================
- Coverage   94.48%   94.34%   -0.15%     
==========================================
  Files         239      246       +7     
  Lines       10468    10809     +341     
  Branches      998     1034      +36     
==========================================
+ Hits         9891    10198     +307     
- Misses        577      611      +34
Impacted Files Coverage Δ
packages/opentelemetry-plugin-http/src/http.ts 97.72% <ø> (ø) ⬆️
packages/opentelemetry-plugin-http/src/utils.ts 97.4% <100%> (+0.14%) ⬆️
...es/opentelemetry-plugin-express/test/utils.test.ts 100% <100%> (ø)
...ckages/opentelemetry-plugin-express/src/version.ts 100% <100%> (ø)
packages/opentelemetry-plugin-express/src/types.ts 100% <100%> (ø)
...pentelemetry-exporter-prometheus/src/prometheus.ts 90% <100%> (ø) ⬆️
...lemetry-plugin-http/test/functionals/utils.test.ts 99.4% <100%> (+0.03%) ⬆️
packages/opentelemetry-plugin-express/src/utils.ts 95.45% <95.45%> (ø)
...ckages/opentelemetry-plugin-express/src/express.ts 98.85% <98.85%> (ø)
.../opentelemetry-plugin-express/test/express.test.ts 99.14% <99.14%> (ø)
... and 172 more

@dyladan dyladan added the Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) label Feb 20, 2020
@mayurkale22 mayurkale22 merged commit 28b9b74 into open-telemetry:master Feb 20, 2020
@mayurkale22 mayurkale22 deleted the remove_deprecated_methods branch February 20, 2020 16:02
dyladan pushed a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants