-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: updated the minimum version of node from 8.0.0 to 8.5.0 #764
Conversation
Can you please also add to the README that our minimum supported version is |
Codecov Report
@@ Coverage Diff @@
## master #764 +/- ##
==========================================
+ Coverage 90.57% 95.95% +5.37%
==========================================
Files 239 130 -109
Lines 11684 5860 -5824
Branches 1098 539 -559
==========================================
- Hits 10583 5623 -4960
+ Misses 1101 237 -864
|
Is there any section of the README that you recommend putting the supported version in. I put it in |
@dyladan Can you help me debug why its failing in CI when you get a chance? I dont have access to it and |
This is no longer needed as we have addressed the support matrix |
) Co-authored-by: Naseem <[email protected]>
Which problem is this PR solving?
#711
Short description of the changes
Updated the minimum version of nodeJS support from 8.0.0 to 8.5.0