-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugin-http): sync. specs for statuscode #719
Merged
dyladan
merged 1 commit into
open-telemetry:master
from
VilledeMontreal:feature/specs-statuscode
Jan 28, 2020
Merged
feat(plugin-http): sync. specs for statuscode #719
dyladan
merged 1 commit into
open-telemetry:master
from
VilledeMontreal:feature/specs-statuscode
Jan 28, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlivierAlbertini
requested review from
bg451,
dyladan,
markwolff,
mayurkale22,
obecny,
rochdev and
vmarchaud
as code owners
January 22, 2020 17:06
Codecov Report
@@ Coverage Diff @@
## master #719 +/- ##
==========================================
- Coverage 92.75% 91.01% -1.75%
==========================================
Files 228 225 -3
Lines 10451 10401 -50
Branches 941 953 +12
==========================================
- Hits 9694 9466 -228
- Misses 757 935 +178
|
OlivierAlbertini
force-pushed
the
feature/specs-statuscode
branch
from
January 22, 2020 17:26
1410361
to
0639737
Compare
dyladan
approved these changes
Jan 22, 2020
mayurkale22
reviewed
Jan 22, 2020
mayurkale22
approved these changes
Jan 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
dyladan
approved these changes
Jan 22, 2020
mayurkale22
added
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
Merge:LGTM
This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
labels
Jan 22, 2020
vmarchaud
approved these changes
Jan 25, 2020
test: fix and add tests closes open-telemetry#642 Signed-off-by: Olivier Albertini <[email protected]>
OlivierAlbertini
force-pushed
the
feature/specs-statuscode
branch
from
January 26, 2020 14:07
3abe44f
to
cd8dec7
Compare
dyladan
approved these changes
Jan 27, 2020
markwolff
approved these changes
Jan 27, 2020
obecny
approved these changes
Jan 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
Merge:LGTM
This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
CanonicalCode
according to specs.I try to use the benchmark system we have, see my sample code here : https://gist.github.com/OlivierAlbertini/9505254b713b9db5f60168ed3fa4e437
But the result is a bit random (on my macbook pro 2016). I would like to know which one is faster. Any insight ?
If we want to share this code with the web, I think we should discuss it and resolve it in a separate PR.