Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 0.3.2 (patch) release proposal #659

Merged
merged 3 commits into from
Jan 3, 2020

Conversation

mayurkale22
Copy link
Member

@mayurkale22 mayurkale22 commented Jan 2, 2020

@codecov-io
Copy link

codecov-io commented Jan 2, 2020

Codecov Report

Merging #659 into master will decrease coverage by 3.29%.
The diff coverage is 12%.

@@           Coverage Diff            @@
##           master    #659     +/-   ##
========================================
- Coverage   94.79%   91.5%   -3.3%     
========================================
  Files         136     216     +80     
  Lines        7778   10132   +2354     
  Branches      666     916    +250     
========================================
+ Hits         7373    9271   +1898     
- Misses        405     861    +456
Impacted Files Coverage Δ
...ckages/opentelemetry-plugin-mongodb/src/version.ts 0% <0%> (ø)
...ges/opentelemetry-scope-async-hooks/src/version.ts 0% <0%> (ø) ⬆️
packages/opentelemetry-plugin-https/src/version.ts 0% <0%> (ø) ⬆️
packages/opentelemetry-plugin-dns/src/version.ts 0% <0%> (ø) ⬆️
...kages/opentelemetry-exporter-jaeger/src/version.ts 0% <0%> (ø) ⬆️
packages/opentelemetry-plugin-http/src/version.ts 0% <0%> (ø) ⬆️
packages/opentelemetry-plugin-redis/src/version.ts 0% <0%> (ø) ⬆️
packages/opentelemetry-tracing/src/version.ts 0% <0%> (ø) ⬆️
packages/opentelemetry-web/src/version.ts 0% <0%> (ø)
packages/opentelemetry-metrics/src/version.ts 0% <0%> (ø) ⬆️
... and 111 more

@dyladan
Copy link
Member

dyladan commented Jan 3, 2020

It looks like some of the version.ts files weren't generated. Can you run lerna run compile again to make sure they are all up to date?

@mayurkale22
Copy link
Member Author

It looks like some of the version.ts files weren't generated. Can you run lerna run compile again to make sure they are all up to date?

I did that before, looks like all versions.ts files are available with correct version. Can you pls check again if I am missing anything else.

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have 14 examples, 30 packages, getting-started/traced-example - 1, main package.json - 1
14 + 30*2 + 1 + 1 = 76 files to be changed, I see 73 files changed, what is missing then

@obecny
Copy link
Member

obecny commented Jan 3, 2020

sry I checked that on different branch, 29 packages so 74 files should be changed

@mayurkale22
Copy link
Member Author

sry I checked that on different branch, 29 packages so 74 files should be changed

getting-started/* is missing.

@vmarchaud
Copy link
Member

vmarchaud commented Jan 3, 2020

For #636, its already 9pm for me so i will not have the time to address comments on my PR today. I think that's fine to skip it for this release.

EDIT: Alternatively, if someone want to move it forward by pushing to my branch that's fine for me too, any contributors should have the permission to do so.

@mayurkale22
Copy link
Member Author

For #636, its already 9pm for me so i will not have the time to address comments on my PR today. I think that's fine to skip it for this release.

SGTM, I moved it to Alpha v0.3.3 milestone.

@mayurkale22 mayurkale22 merged commit 3669648 into open-telemetry:master Jan 3, 2020
@mayurkale22 mayurkale22 deleted the 0.3.2-proposal branch January 3, 2020 20:27
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
martinkuba pushed a commit to martinkuba/opentelemetry-js that referenced this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants