Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context-base and context-asynchooks packages #65

Merged

Conversation

vmarchaud
Copy link
Member

No description provided.

@vmarchaud vmarchaud force-pushed the pkgs/setup-context-packages branch from 3845389 to 85a075e Compare June 27, 2019 13:06
@mayurkale22 mayurkale22 requested a review from rochdev June 27, 2019 16:53
Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, added a few comments.

packages/opentelemetry-context-asynchooks/README.md Outdated Show resolved Hide resolved
packages/opentelemetry-context-base/tsconfig-release.json Outdated Show resolved Hide resolved
packages/opentelemetry-context-asynchooks/package.json Outdated Show resolved Hide resolved
@vmarchaud vmarchaud force-pushed the pkgs/setup-context-packages branch from 85a075e to 4eaccff Compare June 28, 2019 09:15
Copy link
Member

@rochdev rochdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit related to the package name, but otherwise looks good.

packages/opentelemetry-context-asynchooks/package.json Outdated Show resolved Hide resolved
packages/opentelemetry-context-asynchooks/package.json Outdated Show resolved Hide resolved
@vmarchaud vmarchaud force-pushed the pkgs/setup-context-packages branch from 4eaccff to 0273f88 Compare June 28, 2019 13:26
@mayurkale22 mayurkale22 requested a review from rochdev June 28, 2019 17:03
Copy link
Member

@rochdev rochdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The folder should be renamed to match the package name.

@vmarchaud vmarchaud force-pushed the pkgs/setup-context-packages branch 2 times, most recently from acc0760 to 10ab1bb Compare June 30, 2019 10:18
@mayurkale22 mayurkale22 requested a review from rochdev July 1, 2019 17:20
@vmarchaud
Copy link
Member Author

@rochdev Could you look at the PR again ? I believe it's fine now

@vmarchaud vmarchaud force-pushed the pkgs/setup-context-packages branch from 0ce8fda to 10ab1bb Compare July 1, 2019 19:30
@vmarchaud vmarchaud force-pushed the pkgs/setup-context-packages branch from 10ab1bb to dbaa8ab Compare July 1, 2019 19:30
@mayurkale22 mayurkale22 merged commit a60e4b1 into open-telemetry:master Jul 2, 2019
dyladan pushed a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
dyladan added a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
dyladan added a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants