-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add context-base and context-asynchooks packages #65
Add context-base and context-asynchooks packages #65
Conversation
3845389
to
85a075e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, added a few comments.
packages/opentelemetry-context-asynchooks/tsconfig-release.json
Outdated
Show resolved
Hide resolved
85a075e
to
4eaccff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit related to the package name, but otherwise looks good.
4eaccff
to
0273f88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The folder should be renamed to match the package name.
acc0760
to
10ab1bb
Compare
@rochdev Could you look at the PR again ? I believe it's fine now |
0ce8fda
to
10ab1bb
Compare
10ab1bb
to
dbaa8ab
Compare
No description provided.