🤖Add codecov #64
Merged
🤖Add codecov #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codecov.yml
Outdated
| status: | ||
| project: | ||
| default: | ||
| target: "1%" |
There was a problem hiding this comment.
Does this mean all files?
There was a problem hiding this comment.
Does this mean all files?
Currently, Yes. I think we can use https://docs.codecov.io/docs/flags to set target for individual packages.
I am still working on this PR, will change to "Ready for Review" when it's ready.
codecov.yml
Outdated
| project: | ||
| default: | ||
| target: "1%" | ||
| patch: |
There was a problem hiding this comment.
What does it mean to disable code coverage for patch?
mayurkale22
force-pushed
the
codecov
branch
12 times, most recently
from
3e91703 to
fa0402f
Compare
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
=======================================
Coverage ? 100%
=======================================
Files ? 2
Lines ? 16
Branches ? 0
=======================================
Hits ? 16
Misses ? 0
Partials ? 0 |
mayurkale22
requested review from
danielkhan,
iredelmeier and
justindsmith
as code owners
bg451
approved these changes
Jun 27, 2019
rochdev
reviewed
Jun 28, 2019
| @@ -6,8 +6,8 @@ | |||
| "types": "build/src/index.d.ts", | |||
| "repository": "open-telemetry/opentelemetry-js", | |||
| "scripts": { | |||
| "test": "nyc ts-mocha -p ./tsconfig.json test/**/*.ts", | |||
| "tdd": "yarn run test -- --watch-extensions ts --watch", | |||
| "test": "nyc ts-mocha -p tsconfig.json test/**/*.ts", | |||
There was a problem hiding this comment.
We should attempt to use the built-in v8 coverage reporting in a later revision since it's a lot faster than NYC.
rochdev
approved these changes
Jun 28, 2019
dyladan
added a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
dyladan
added a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still work in progress (Draft), comments are welcome!Fixes #12
Codecov link:
https://codecov.io/gh/open-telemetry/opentelemetry-js/commit/3e91703b4528c55be22c2f001b2c957456b23ce9