-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugin-http): http.url attribute #580
Merged
mayurkale22
merged 2 commits into
open-telemetry:master
from
OlivierAlbertini:feature/typo-url-composition
Dec 2, 2019
Merged
fix(plugin-http): http.url attribute #580
mayurkale22
merged 2 commits into
open-telemetry:master
from
OlivierAlbertini:feature/typo-url-composition
Dec 2, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlivierAlbertini
added
enhancement
New feature or request
bug
Something isn't working
and removed
enhancement
New feature or request
labels
Nov 30, 2019
OlivierAlbertini
force-pushed
the
feature/typo-url-composition
branch
2 times, most recently
from
November 30, 2019 16:16
f8694cf
to
c62df3e
Compare
closes open-telemetry#579 Signed-off-by: Olivier Albertini <[email protected]>
OlivierAlbertini
force-pushed
the
feature/typo-url-composition
branch
from
November 30, 2019 16:21
c62df3e
to
9773f9c
Compare
OlivierAlbertini
requested review from
bg451,
danielkhan,
markwolff,
mayurkale22,
obecny,
rochdev and
vmarchaud
as code owners
November 30, 2019 16:24
Codecov Report
@@ Coverage Diff @@
## master #580 +/- ##
=========================================
+ Coverage 90.43% 90.54% +0.1%
=========================================
Files 154 155 +1
Lines 7924 8025 +101
Branches 697 703 +6
=========================================
+ Hits 7166 7266 +100
- Misses 758 759 +1
|
mayurkale22
approved these changes
Dec 1, 2019
vmarchaud
approved these changes
Dec 1, 2019
obecny
approved these changes
Dec 2, 2019
mayurkale22
added
the
Merge:LGTM
This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
label
Dec 2, 2019
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
…elemetry#580) * fix: redis instrumentation loses context when using callbacks * fix: rename test * fix: merge new test into existing describe * fix: refactor context.with as requested * fix: remove redundant callbackThis const * fix: move originalContext to inside if
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
Merge:LGTM
This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #579
Short description of the changes