Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add ioredis to instrumentation list #558

Merged
merged 91 commits into from
Dec 24, 2019
Merged
Changes from 1 commit
Commits
Show all changes
91 commits
Select commit Hold shift + click to select a range
5194ce1
Add ioredis
naseemkullah Nov 21, 2019
b83c601
Merge branch 'master' into ioredis
naseemkullah Nov 21, 2019
78c8096
remove unused util
naseemkullah Nov 21, 2019
cee0a62
Merge branch 'master' into ioredis
naseemkullah Nov 21, 2019
51c5761
Console error when callback cannot be found in command object
naseemkullah Nov 22, 2019
3601d2e
fix
naseemkullah Nov 22, 2019
2d55757
Merge branch 'ioredis' of github.com:naseemkullah/opentelemetry-js in…
naseemkullah Nov 22, 2019
339d7e4
There never seems to be a this.address
naseemkullah Nov 22, 2019
81f025e
err can be made non-optional here since it is currently always passed in
naseemkullah Nov 22, 2019
9c22f7c
No address property
naseemkullah Nov 22, 2019
04210a0
Update packages
naseemkullah Nov 23, 2019
2912a72
Adjust value of DB_STATEMENT
naseemkullah Nov 23, 2019
c6547d4
Add DB_TYPE attribute
naseemkullah Nov 23, 2019
ea7dd9b
Handle async/await ioredis commands that have no cb
naseemkullah Nov 24, 2019
9646836
Fix promise handling and adjust attributes
naseemkullah Nov 25, 2019
f7a7d78
Use template literal
naseemkullah Nov 25, 2019
4bc1644
Add same comments as pg plugin for promise handling
naseemkullah Nov 25, 2019
d3bfc0b
Use endSpan function
naseemkullah Nov 25, 2019
cecbaad
Merge branch 'master' into ioredis
naseemkullah Nov 25, 2019
fe69ce9
fix: combine 2 lines into 1
naseemkullah Nov 26, 2019
ced0767
chore: update modules
naseemkullah Nov 26, 2019
407a0bc
Merge branch 'master' into ioredis
naseemkullah Nov 26, 2019
f028231
fix: tests
naseemkullah Nov 26, 2019
8e6154b
Merge branch 'ioredis' of github.com:naseemkullah/opentelemetry-js in…
naseemkullah Nov 26, 2019
fab7e83
style: rename error
naseemkullah Nov 26, 2019
5a1638b
docs: update min version
naseemkullah Nov 26, 2019
16a1f40
fix: nullish coalescing
naseemkullah Nov 26, 2019
a6b5f63
Revert "fix: nullish coalescing"
naseemkullah Nov 26, 2019
378ed8f
Merge branch 'master' into ioredis
naseemkullah Nov 26, 2019
b002cfa
fix: make DB_TYPE a const
naseemkullah Nov 28, 2019
f260d70
Merge branch 'ioredis' of github.com:naseemkullah/opentelemetry-js in…
naseemkullah Nov 28, 2019
bef1af5
fix: update links
naseemkullah Nov 28, 2019
94cda5b
fix: move ioredis to dependencies, update @types/ioredis
naseemkullah Nov 28, 2019
c872bf7
fix: add a comment about nullish coalescing
naseemkullah Nov 28, 2019
7609929
fix: move done from try/catch to finally
naseemkullah Nov 28, 2019
c62f65b
Merge branch 'master' into ioredis
naseemkullah Nov 28, 2019
b511231
fix: gts fix
naseemkullah Nov 28, 2019
09a0af3
Merge branch 'ioredis' of github.com:naseemkullah/opentelemetry-js in…
naseemkullah Nov 28, 2019
d32605c
Merge branch 'master' into ioredis
naseemkullah Nov 30, 2019
626bcc2
fix: callback type
naseemkullah Nov 30, 2019
3820fd5
style: move cb tests up
naseemkullah Nov 30, 2019
69f9043
fix: gts
naseemkullah Nov 30, 2019
e0d4bd0
fix: remove unused code
naseemkullah Nov 30, 2019
2ef5a5c
fix: update ts-node
naseemkullah Nov 30, 2019
a5ee375
fix: nested cb for cb style call tests
naseemkullah Nov 30, 2019
4771412
fix: prevent span leaking with better if statement, add else
naseemkullah Dec 2, 2019
c707c4e
Merge branch 'master' into ioredis
naseemkullah Dec 2, 2019
af7470d
fix: remove unneeded || undefined
naseemkullah Dec 5, 2019
b4ecd05
Merge branch 'master' into ioredis
naseemkullah Dec 5, 2019
540b0ca
fix: ioredis as dev dependency
naseemkullah Dec 6, 2019
75c220b
Merge branch 'master' into ioredis
naseemkullah Dec 6, 2019
8c0f1f4
fix: do not return a new promise, end span in .then handler
naseemkullah Dec 7, 2019
d6bdd0e
fix: if statement
naseemkullah Dec 7, 2019
22bc3ed
fix: guard against args not being an array
naseemkullah Dec 7, 2019
af0dfe7
fix: tests
naseemkullah Dec 7, 2019
2b68d77
Merge branch 'master' into ioredis
naseemkullah Dec 7, 2019
ea6b5f3
Update packages/opentelemetry-plugin-ioredis/README.md
naseemkullah Dec 9, 2019
afe9fd3
docs: remove sentence from Usage section
naseemkullah Dec 9, 2019
159d9d1
fix: remove unecessary check, rename functions
naseemkullah Dec 9, 2019
136d0b5
fix: rename functions
naseemkullah Dec 9, 2019
6378fb8
Merge branch 'master' into ioredis
naseemkullah Dec 12, 2019
9934327
fix: port type is number
naseemkullah Dec 12, 2019
949c9d4
docs: add link to available options
naseemkullah Dec 12, 2019
0fc75ea
fix: always convert string port to number
naseemkullah Dec 12, 2019
43b06a3
fix: improve inherit options type from ioredis types
naseemkullah Dec 13, 2019
b0c5311
fix: options always exists
naseemkullah Dec 13, 2019
c4a6c07
fix: options is always there and all we need
naseemkullah Dec 13, 2019
0728a13
test: streamify scanning
naseemkullah Dec 14, 2019
09c5386
test: lua
naseemkullah Dec 15, 2019
664cab5
test: cb tests were flawed
naseemkullah Dec 15, 2019
79fdef3
fix: trace cb invocations properly
naseemkullah Dec 15, 2019
537f193
refactor: same code handles cb and promise style invocations
naseemkullah Dec 15, 2019
0259654
fix: update packages
naseemkullah Dec 15, 2019
842a780
fix: db statement format
naseemkullah Dec 15, 2019
151b679
test: add pipeline test
naseemkullah Dec 15, 2019
2d76a4f
fix: allow arguments to be greater than 1
naseemkullah Dec 15, 2019
2b16305
fix: gts
naseemkullah Dec 16, 2019
d4a59c0
Merge branch 'master' into ioredis
naseemkullah Dec 16, 2019
2c9217c
test: trace client connection/disconnection
naseemkullah Dec 19, 2019
b5f616f
Merge branch 'master' into ioredis
naseemkullah Dec 19, 2019
3b47e26
feat: trace connection
naseemkullah Dec 19, 2019
f36bff1
Merge branch 'master' into ioredis
OlivierAlbertini Dec 20, 2019
7b3a94e
test: pubsub
naseemkullah Dec 21, 2019
1fafbd5
Merge branch 'ioredis' of github.com:naseemkullah/opentelemetry-js in…
naseemkullah Dec 21, 2019
dec624f
Merge branch 'master' into ioredis
naseemkullah Dec 21, 2019
d7af162
fix: quit instead of disconnect
naseemkullah Dec 21, 2019
37de078
Merge branch 'ioredis' of github.com:naseemkullah/opentelemetry-js in…
naseemkullah Dec 21, 2019
8585926
Merge branch 'master' into ioredis
naseemkullah Dec 24, 2019
d730512
Merge branch 'master' into ioredis
naseemkullah Dec 24, 2019
9cb26df
fix: update packages
naseemkullah Dec 24, 2019
23462da
feat: use test-utils package
naseemkullah Dec 24, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: move ioredis to dependencies, update @types/ioredis
naseemkullah committed Nov 28, 2019
commit 94cda5bc22bf9181a01febf9d85cc41a150d7028
4 changes: 2 additions & 2 deletions packages/opentelemetry-plugin-ioredis/package.json
Original file line number Diff line number Diff line change
@@ -45,14 +45,13 @@
"devDependencies": {
"@opentelemetry/node": "^0.2.0",
"@opentelemetry/tracing": "^0.2.0",
"@types/ioredis": "^4.0.19",
"@types/ioredis": "^4.0.20",
"@types/mocha": "^5.2.7",
"@types/node": "^12.12.14",
"@types/shimmer": "^1.0.1",
"codecov": "^3.6.1",
"cross-env": "^6.0.3",
"gts": "^1.1.2",
"ioredis": "^4.14.1",
"mocha": "^6.2.2",
"nyc": "^14.1.1",
"rimraf": "^3.0.0",
@@ -63,6 +62,7 @@
"typescript": "3.7.2"
},
"dependencies": {
"ioredis": "^4.14.1",
naseemkullah marked this conversation as resolved.
Show resolved Hide resolved
"@opentelemetry/core": "^0.2.0",
"@opentelemetry/types": "^0.2.0",
"shimmer": "^1.2.1"