-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugin-http): adapt to current @types/node #548
fix(plugin-http): adapt to current @types/node #548
Conversation
Codecov Report
@@ Coverage Diff @@
## master #548 +/- ##
==========================================
- Coverage 92.98% 90.13% -2.85%
==========================================
Files 147 142 -5
Lines 7694 7057 -637
Branches 654 641 -13
==========================================
- Hits 7154 6361 -793
- Misses 540 696 +156
|
aa4f249
to
ab1ff75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm,
does it mean that this PR, can be closed then in favour of this ?
yes, one is enough. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also upgrade @types/node to ^12.12.8
?
I can adapt the package.json files. Only http/https or all 24 packages? |
I see no reason not to do all 24 |
ab1ff75
to
6606ec4
Compare
@Flarna are you going to update the other |
@dyladan Nope, I updated only http/https and only @types/node. |
Which problem is this PR solving?
fixes #541
Short description of the changes
Adapt http/https plugin to @types/node 12.12.9
Refs: #545