-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fixing issue when metric time is 0 in document-load plugin #546
Merged
mayurkale22
merged 3 commits into
open-telemetry:master
from
obecny:document_load_fix_time0
Nov 20, 2019
Merged
chore: fixing issue when metric time is 0 in document-load plugin #546
mayurkale22
merged 3 commits into
open-telemetry:master
from
obecny:document_load_fix_time0
Nov 20, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obecny
requested review from
bg451,
danielkhan,
markwolff,
mayurkale22,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
November 18, 2019 13:25
dyladan
approved these changes
Nov 18, 2019
mayurkale22
approved these changes
Nov 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #546 +/- ##
==========================================
- Coverage 92.28% 90.24% -2.05%
==========================================
Files 151 149 -2
Lines 7337 7449 +112
Branches 647 662 +15
==========================================
- Hits 6771 6722 -49
- Misses 566 727 +161
|
/cc @draffensperger |
bg451
approved these changes
Nov 19, 2019
markwolff
approved these changes
Nov 20, 2019
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
…lemetry#546) Co-authored-by: Daniel Dyla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
error image