Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect CHANGELOG entry on main (v1.next) #5280

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

chancancode
Copy link
Contributor

I was reviewing the v1.next release PRs, caught one of the CHANGELOG entry pointing to the wrong issue number, which made it into #5274. Figured we could still get that fixed before the release goes out

@chancancode chancancode requested a review from a team as a code owner December 17, 2024 22:00
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.67%. Comparing base (8ab52d5) to head (838fab4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5280      +/-   ##
==========================================
+ Coverage   94.66%   94.67%   +0.01%     
==========================================
  Files         322      322              
  Lines        8058     8058              
  Branches     1632     1632              
==========================================
+ Hits         7628     7629       +1     
+ Misses        430      429       -1     

see 1 file with indirect coverage changes

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this 👍

@pichlermarc pichlermarc added this pull request to the merge queue Dec 18, 2024
Merged via the queue into open-telemetry:main with commit 0c11fc6 Dec 18, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants