Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): adapt workflow to use supported npm versions #5277

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Dec 17, 2024

Which problem is this PR solving?

  • limit to npm@<11 on Node 18 as [email protected] dropped support for it via the engines field (README.md is not updated yet)
  • Updates benchmark workflow to latest LTS Node.js version
  • Updates Windows tests to run on Node.js v20

@pichlermarc pichlermarc requested a review from a team as a code owner December 17, 2024 11:48
@pichlermarc pichlermarc changed the title fix(ci): adapt workflow to use correct npm versions fix(ci): adapt workflow to use supported npm versions Dec 17, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.66%. Comparing base (84cce75) to head (41a1ef3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5277      +/-   ##
==========================================
- Coverage   94.67%   94.66%   -0.02%     
==========================================
  Files         322      322              
  Lines        8058     8058              
  Branches     1632     1632              
==========================================
- Hits         7629     7628       -1     
- Misses        429      430       +1     

see 1 file with indirect coverage changes

@pichlermarc pichlermarc added this pull request to the merge queue Dec 17, 2024
Merged via the queue into open-telemetry:main with commit 8ab52d5 Dec 17, 2024
20 checks passed
@pichlermarc pichlermarc deleted the chore/fix-ci branch December 17, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants