-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: prepare release script to run on v1.x branch #5276
ci: prepare release script to run on v1.x branch #5276
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v1.x #5276 +/- ##
=======================================
Coverage 94.66% 94.66%
=======================================
Files 322 322
Lines 8058 8058
Branches 1632 1632
=======================================
Hits 7628 7628
Misses 430 430 |
38fdc69
to
bd68166
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my review doesn't really count, but FWIW, I did check that:
- everything in these two files seems to be updated appropriately, and
- I didn't see anything in the
scripts/*.js
referenced here that would need to be updated
Trying to understand: after |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth having a "1.x" section or note to doc/contributing/releasing.md?
@maryliag yes, we want to publish from both:
This workflow gets changed only on the |
Good point, updated it here 69675f8 - steps largely remain the same :) |
I'll port the docs changes forward to |
duh... completely missed this was on v1 branch! My mistake, now makes sense 😄 |
Co-authored-by: Marylia Gutierrez <[email protected]>
Which problem is this PR solving?
Once we merge next into
main
, we'll need to continue publishing onv1.x
.This PR prepares the release scripts to do that. I'll re-target to the
v1.x
branch once we have set it up.Steps:
v1.x
branchv1.x
Then we can
next
tomain
(the other way around for once)From then on we can continue backporting to and releasing from
v1.x
, independently of what's onmain