-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: zipkin-exporter: don't export after shutdown #526
fix: zipkin-exporter: don't export after shutdown #526
Conversation
2f0ea0b
to
b9a35bd
Compare
Codecov Report
@@ Coverage Diff @@
## master #526 +/- ##
===========================================
+ Coverage 49.2% 96.52% +47.31%
===========================================
Files 47 132 +85
Lines 1392 6361 +4969
Branches 143 566 +423
===========================================
+ Hits 685 6140 +5455
+ Misses 707 221 -486
|
b9a35bd
to
516d86a
Compare
According to spec and exporter should return FailedNotRetryable error after shutdown was called.
516d86a
to
cb5d416
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like same thing needs to be implemented for Jaeger exporter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, one comment
Seems we have an issue with the just released node type definitions (DefinitelyTyped/DefinitelyTyped#40118):
|
Which problem is this PR solving?
According to spec and exporter should return
FailedNotRetryable
errorafter shutdown was called.
see https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/sdk-tracing.md#shutdown-1
Short description of the changes
Remember that
shutdown()
was called and if yes immediate call callback with error.