Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(circleci): remove duplicate compile step #510

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

mayurkale22
Copy link
Member

@mayurkale22 mayurkale22 commented Nov 8, 2019

Which problem is this PR solving?

@codecov-io
Copy link

codecov-io commented Nov 8, 2019

Codecov Report

Merging #510 into master will increase coverage by 43.33%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #510       +/-   ##
===========================================
+ Coverage    49.2%   92.54%   +43.33%     
===========================================
  Files          47      146       +99     
  Lines        1392     7221     +5829     
  Branches      143      623      +480     
===========================================
+ Hits          685     6683     +5998     
+ Misses        707      538      -169
Impacted Files Coverage Δ
.../opentelemetry-core/src/trace/spancontext-utils.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-web/src/WebTracer.ts 100% <0%> (ø) ⬆️
...opentelemetry-core/src/trace/globaltracer-utils.ts 100% <0%> (ø) ⬆️
.../opentelemetry-core/test/metrics/NoopMeter.test.ts 97.22% <0%> (ø)
...emetry-metrics/src/export/ConsoleMetricExporter.ts 93.75% <0%> (ø)
...entelemetry-plugin-dns/src/enums/AttributeNames.ts 100% <0%> (ø)
...ry-plugin-dns/test/functionals/dns-disable.test.ts 100% <0%> (ø)
...entelemetry-exporter-jaeger/test/transform.test.ts 100% <0%> (ø)
...opentelemetry-base/test/resources/resource.test.ts 100% <0%> (ø)
packages/opentelemetry-tracing/src/config.ts 100% <0%> (ø)
... and 111 more

@@ -68,9 +68,6 @@ browsers_unit_tests: &browsers_unit_tests
- run:
name: Install Dependencies
command: yarn install
- run:
name: Compile code
command: yarn compile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this also be removed in node_unit_tests?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the issue is a permissions one. https://docs.npmjs.com/misc/scripts#user

Try enabling the unsafe-perm flag and removing yarn compile from the node_unit_tests

@mayurkale22 mayurkale22 merged commit 8a81929 into open-telemetry:master Nov 13, 2019
@mayurkale22 mayurkale22 deleted the remove_compile_step branch November 13, 2019 17:54
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
martinkuba pushed a commit to martinkuba/opentelemetry-js that referenced this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants