-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(circleci): remove duplicate compile step #510
chore(circleci): remove duplicate compile step #510
Conversation
Codecov Report
@@ Coverage Diff @@
## master #510 +/- ##
===========================================
+ Coverage 49.2% 92.54% +43.33%
===========================================
Files 47 146 +99
Lines 1392 7221 +5829
Branches 143 623 +480
===========================================
+ Hits 685 6683 +5998
+ Misses 707 538 -169
|
f5670fe
to
110c47d
Compare
@@ -68,9 +68,6 @@ browsers_unit_tests: &browsers_unit_tests | |||
- run: | |||
name: Install Dependencies | |||
command: yarn install | |||
- run: | |||
name: Compile code | |||
command: yarn compile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this also be removed in node_unit_tests
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried, but build is failing after that https://app.circleci.com/jobs/github/open-telemetry/opentelemetry-js/7777
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the issue is a permissions one. https://docs.npmjs.com/misc/scripts#user
Try enabling the unsafe-perm
flag and removing yarn compile from the node_unit_tests
c89bf8c
to
305d5f6
Compare
Co-authored-by: Valentin Marchaud <[email protected]>
Co-authored-by: Valentin Marchaud <[email protected]>
Which problem is this PR solving?
Updates coverage runs take 2 min out of every circleci build #481
We can save ~25secs during each build
Compile step is already part of
prepare
script, which runs onyarn install
.