-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fixes # 4533] Replaced cpx2 with local test module #5077
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5077 +/- ##
=======================================
Coverage 93.27% 93.27%
=======================================
Files 317 317
Lines 8195 8195
Branches 1641 1641
=======================================
Hits 7644 7644
Misses 551 551 |
@pichlermarc Please review my changes. Changelog and unit test are failing: |
# This is the 1st commit message: Added local test pkg # This is the commit message #2: add type declaration for test-none-core-module # This is the commit message #3: Replaced cpx2 with a local module # This is the commit message open-telemetry#4: fixed lint errors
97daf90
to
e1fd391
Compare
e1fd391
to
fe6eb79
Compare
there's a massive amount of changes in |
WRT to the changelog, usually someone with Triage permissions decides if the entry needs a changelog or not by applying the |
@pichlermarc restored both files. I see this message on this PR too. Note: TY for your patience and guidance. |
The most likely reason the diff in https://github.com/open-telemetry/opentelemetry-js/pull/5077/files/fe6eb7917fd994c88cb4e6280dc04ef4b120b072#diff-053150b640a7ce75eff69d1a22cae7f0f94ad64ce9a855db544dda0929316519 is that you might've run something like
A large part of our contributions never touch any dependencies so this PR was a bit of a special case. The remaining conflicts with the Transitive dependencies often change and we use a lot of tooling to test against Node.js and in a browser-like environment. We've made the experience that just pinning the We made the decision to also check-in a But adding the
That will resolve the conflicts and make it so that we can merge the PR 🙂 |
Which problem is this PR solving?
Replaced the external dependency of cpx2 package, with a local test module (
test-non-core-module
) that mimics the cpx2 package. Made the required changes in RequireInTheMiddleSingleton.Fixes #4533
Short description of the changes
Added the module test-non-core-module with package.json.
Updated RequireInTheMiddleSingleton.test.ts
Also updated package.json to remove the cpx2 dependency.
Changelog Entry
This change does not require a changelog entry as it only modifies internal logic without impacting public APIs.
How Has This Been Tested?
npm run compile
npm test
with no errors or warningsChecklist: