Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added limitation in ot-shim readme #5072

Merged
merged 5 commits into from
Oct 23, 2024

Conversation

mercybassey
Copy link
Contributor

Which problem is this PR solving?

This PR informs users that the OpenTracing shim doesn't include a scope manager.

Fixes #2700

Short description of the changes

This PR updates the OpenTracing shim Readme.md file by adding a limitation section; informing users that the OpenTracing shim doesn't include a scope manager.

Type of change

  • This change requires a documentation update

How Has This Been Tested?

No test was created/run

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@mercybassey mercybassey requested a review from a team as a code owner October 15, 2024 14:29
@mercybassey
Copy link
Contributor Author

Hi @pichlermarc I'd appreciate your review. Thanks.

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for working on this - a few suggestions as per my understanding of the issue.

packages/opentelemetry-shim-opentracing/README.md Outdated Show resolved Hide resolved
packages/opentelemetry-shim-opentracing/README.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.17%. Comparing base (006fe44) to head (2556bc8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5072      +/-   ##
==========================================
- Coverage   93.18%   93.17%   -0.02%     
==========================================
  Files         315      315              
  Lines        8086     8086              
  Branches     1617     1617              
==========================================
- Hits         7535     7534       -1     
- Misses        551      552       +1     

see 1 file with indirect coverage changes

@mercybassey
Copy link
Contributor Author

thanks for working on this - a few suggestions as per my understanding of the issue.

@pichlermarc I have committed your suggestions. Thanks.

@pichlermarc pichlermarc added this pull request to the merge queue Oct 23, 2024
Merged via the queue into open-telemetry:main with commit 4497ee3 Oct 23, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ot-shim: document the omission of scope manager
2 participants