Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use venv in w3c trace context test script #5071

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Oct 15, 2024

Which problem is this PR solving?

Tests are currently failing (see here, probably due to some changes that don't allow the use of pip install with an externally managed environment, like the global one that's supposed to be managed by the system and requires packages to be installed via apt on Ubuntu 24.04). This PR makes the test script use a venv instead to avoid this error.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Local testing (I tested this on Ubuntu 24.04 and it was also happening there)
  • workflow here on this PR

@pichlermarc pichlermarc requested a review from a team as a code owner October 15, 2024 12:45
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.27%. Comparing base (7ed67f9) to head (7d5202e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5071      +/-   ##
==========================================
+ Coverage   93.26%   93.27%   +0.01%     
==========================================
  Files         317      317              
  Lines        8195     8195              
  Branches     1641     1641              
==========================================
+ Hits         7643     7644       +1     
+ Misses        552      551       -1     

see 1 file with indirect coverage changes

@pichlermarc pichlermarc added this pull request to the merge queue Oct 17, 2024
Merged via the queue into open-telemetry:main with commit c208991 Oct 17, 2024
21 of 22 checks passed
@pichlermarc pichlermarc deleted the fix/w3c-tests branch October 17, 2024 08:01
Annosha pushed a commit to Annosha/opentelemetry-js that referenced this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants