Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use nx commands for some scripts #5066

Closed

Conversation

david-luna
Copy link
Contributor

@david-luna david-luna commented Oct 12, 2024

Which problem is this PR solving?

leverage nx (which is used by lerna) and its cache

Short description of the changes

  • replace lerna's commands with nx commands when possible
  • add nx.json to setup task dependencies and build cache
  • update unit test workflow to set the build cache for nx

Type of change

Please delete options that are not relevant.

  • Chore

How Has This Been Tested?

Checklist:

  • Check test workflow to se if build cache takes effect

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.26%. Comparing base (7ed67f9) to head (96e6ac5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5066   +/-   ##
=======================================
  Coverage   93.26%   93.26%           
=======================================
  Files         317      317           
  Lines        8195     8195           
  Branches     1641     1641           
=======================================
  Hits         7643     7643           
  Misses        552      552           

@david-luna
Copy link
Contributor Author

Using nx cache here impacts a lot in the CI and adapting to it would require consensus from maintainers. The dev experience may also be inpacted. I think it's best to have the discussion 1st before presenting a PR

@david-luna david-luna closed this Oct 16, 2024
@david-luna david-luna deleted the dluna/use-nx-commands branch October 16, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant