Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom test instructions for browser-specific tests #5056

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

Annosha
Copy link
Contributor

@Annosha Annosha commented Oct 9, 2024

Fixes: #5046

Packages that also run in browser have browser-specific tests. Adding this information in Running tests CONTRIBUTING.md.

@Annosha Annosha requested a review from a team as a code owner October 9, 2024 07:00
Copy link

linux-foundation-easycla bot commented Oct 9, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.26%. Comparing base (6be903a) to head (a255043).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5056   +/-   ##
=======================================
  Coverage   93.26%   93.26%           
=======================================
  Files         317      317           
  Lines        8195     8195           
  Branches     1641     1641           
=======================================
  Hits         7643     7643           
  Misses        552      552           

CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-authored-by: Trent Mick <[email protected]>
@Annosha
Copy link
Contributor Author

Annosha commented Oct 10, 2024

@trentm thank you for reviewing.
Can we merge this PR now?

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you 🙂

@pichlermarc pichlermarc enabled auto-merge October 14, 2024 09:23
@pichlermarc pichlermarc added this pull request to the merge queue Oct 14, 2024
Merged via the queue into open-telemetry:main with commit 7293e69 Oct 14, 2024
21 checks passed
Annosha added a commit to Annosha/opentelemetry-js that referenced this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add custom tests instructions for specific packages.
3 participants