Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk-node): use warn instead of error on unknown OTEL_NODE_RESOURCE_DETECTORS values #5034

Merged
merged 4 commits into from
Oct 3, 2024

Update experimental/CHANGELOG.md

d51bda9
Select commit
Loading
Failed to load commit list.
Merged

fix(sdk-node): use warn instead of error on unknown OTEL_NODE_RESOURCE_DETECTORS values #5034

Update experimental/CHANGELOG.md
d51bda9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 3, 2024 in 0s

93.27% (-0.13%) compared to f8ab559

View this Pull Request on Codecov

93.27% (-0.13%) compared to f8ab559

Details

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.27%. Comparing base (f8ab559) to head (d51bda9).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
...ental/packages/opentelemetry-sdk-node/src/utils.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5034      +/-   ##
==========================================
- Coverage   93.39%   93.27%   -0.13%     
==========================================
  Files          46      317     +271     
  Lines         712     8194    +7482     
  Branches      120     1640    +1520     
==========================================
+ Hits          665     7643    +6978     
- Misses         47      551     +504
Files with missing lines Coverage Δ
...ental/packages/opentelemetry-sdk-node/src/utils.ts 85.71% <0.00%> (ø)

... and 265 files with indirect coverage changes

View more details on Codecov