Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instr-grpc): update semconv to 1.27 #5002

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

JamieDanielson
Copy link
Member

@JamieDanielson JamieDanielson commented Sep 18, 2024

Which problem is this PR solving?

Short description of the changes

  • use new ATTR_* for stable http/net attributes
  • start adding logic for opt-in options

Question: Should we be using ATTR_* from incubating, or keep using SEMATTRS_*? Asked on http server PR

TODO

  • OTEL_SEMCONV_STABILITY_OPT_IN
  • ATTR_NET_PEER_NAME => ATTR_SERVER_ADDRESS || ATTR_CLIENT_ADDRESS from stable
  • ATTR_NET_PEER_PORT => ATTR_SERVER_PORT || ATTR_CLIENT_PORT from stable

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

  • unit tests

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Nov 25, 2024
Copy link

github-actions bot commented Dec 9, 2024

This PR was closed because it has been stale for 14 days with no activity.

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 56.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 94.53%. Comparing base (f8ab559) to head (5d949bc).
Report is 121 commits behind head on main.

Files with missing lines Patch % Lines
...emetry-instrumentation-grpc/src/instrumentation.ts 56.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5002      +/-   ##
==========================================
+ Coverage   93.39%   94.53%   +1.14%     
==========================================
  Files          46      315     +269     
  Lines         712     8076    +7364     
  Branches      120     1638    +1518     
==========================================
+ Hits          665     7635    +6970     
- Misses         47      441     +394     
Files with missing lines Coverage Δ
...emetry-instrumentation-grpc/src/instrumentation.ts 90.50% <56.00%> (ø)

... and 270 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant