Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(exporters)!: rewrite exporter config logic #4971

Merged
merged 7 commits into from
Sep 30, 2024

Merge branch 'main' into feat/node-exporter-config-rewrite

e24837d
Select commit
Loading
Failed to load commit list.
Merged

feat(exporters)!: rewrite exporter config logic #4971

Merge branch 'main' into feat/node-exporter-config-rewrite
e24837d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 30, 2024 in 0s

93.26% (-0.14%) compared to f8ab559

View this Pull Request on Codecov

93.26% (-0.14%) compared to f8ab559

Details

Codecov Report

Attention: Patch coverage is 95.59322% with 13 lines in your changes missing coverage. Please review.

Project coverage is 93.26%. Comparing base (f8ab559) to head (e24837d).
Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
...se/src/platform/browser/OTLPExporterBrowserBase.ts 20.00% 4 Missing ⚠️
.../src/platform/node/convert-legacy-agent-options.ts 50.00% 4 Missing ⚠️
...grpc-exporter-base/src/OTLPGRPCExporterNodeBase.ts 72.72% 3 Missing ⚠️
...e/src/configuration/otlp-http-env-configuration.ts 95.74% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4971      +/-   ##
==========================================
- Coverage   93.39%   93.26%   -0.14%     
==========================================
  Files          46      317     +271     
  Lines         712     8194    +7482     
  Branches      120     1640    +1520     
==========================================
+ Hits          665     7642    +6977     
- Misses         47      552     +505
Files with missing lines Coverage Δ
...ges/exporter-logs-otlp-grpc/src/OTLPLogExporter.ts 100.00% <ø> (ø)
...ogs-otlp-http/src/platform/node/OTLPLogExporter.ts 100.00% <100.00%> (ø)
...gs-otlp-proto/src/platform/node/OTLPLogExporter.ts 100.00% <100.00%> (ø)
.../exporter-trace-otlp-grpc/src/OTLPTraceExporter.ts 100.00% <ø> (ø)
...e-otlp-http/src/platform/node/OTLPTraceExporter.ts 100.00% <100.00%> (ø)
...-otlp-proto/src/platform/node/OTLPTraceExporter.ts 100.00% <100.00%> (ø)
...porter-metrics-otlp-grpc/src/OTLPMetricExporter.ts 100.00% <ø> (ø)
...-otlp-http/src/platform/node/OTLPMetricExporter.ts 100.00% <100.00%> (ø)
...orter-metrics-otlp-proto/src/OTLPMetricExporter.ts 100.00% <100.00%> (ø)
...ackages/otlp-exporter-base/src/OTLPExporterBase.ts 94.44% <ø> (ø)
... and 13 more

... and 250 files with indirect coverage changes

View more details on Codecov