Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade typescript to 3.6.4 #494

Merged
merged 1 commit into from
Nov 6, 2019

Conversation

mayurkale22
Copy link
Member

Which problem is this PR solving?

  • Attempt one to fix the build.

@codecov-io
Copy link

codecov-io commented Nov 6, 2019

Codecov Report

Merging #494 into master will increase coverage by 1.56%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #494      +/-   ##
==========================================
+ Coverage   95.31%   96.88%   +1.56%     
==========================================
  Files         137      129       -8     
  Lines        6973     6571     -402     
  Branches      596      570      -26     
==========================================
- Hits         6646     6366     -280     
+ Misses        327      205     -122
Impacted Files Coverage Δ
...ckages/opentelemetry-core/src/common/NoopLogger.ts 42.85% <0%> (-14.29%) ⬇️
...metry-core/src/trace/instrumentation/BasePlugin.ts 80.55% <0%> (-5.56%) ⬇️
...entelemetry-exporter-jaeger/test/transform.test.ts 100% <0%> (ø) ⬆️
...pe-async-hooks/test/AsyncHooksScopeManager.test.ts 100% <0%> (ø) ⬆️
.../opentelemetry-exporter-jaeger/test/jaeger.test.ts 100% <0%> (ø) ⬆️
...-document-load/src/enums/PerformanceTimingNames.ts
packages/opentelemetry-web/test/WebTracer.test.ts
...y-plugin-document-load/src/enums/AttributeNames.ts
...entelemetry-plugin-postgres/test/assertionUtils.ts
...es/opentelemetry-plugin-postgres/test/testUtils.ts
... and 15 more

@markwolff
Copy link
Member

This seems to have fixed it! Interestingly, when I SSH'd in previously, the version of typescript in yarn.lock was 3.6.4, so I'm not quite sure why this fixes the problems.

@mayurkale22
Copy link
Member Author

This seems to have fixed it! Interestingly, when I SSH'd in previously, the version of typescript in yarn.lock was 3.6.4, so I'm not quite sure why this fixes the problems.

Strange, the build was failing for gRPC plugin. Did you check the typescript version for that?

@markwolff
Copy link
Member

markwolff commented Nov 6, 2019

This seems to have fixed it! Interestingly, when I SSH'd in previously, the version of typescript in yarn.lock was 3.6.4, so I'm not quite sure why this fixes the problems.

Strange, the build was failing for gRPC plugin. Did you check the typescript version for that?

Actually I was mistaken, despite the yarn.lock resolving to 3.6.4, the typescript version in node_modules is 3.7.2, so it looks like ts version is the issue.

@mayurkale22 mayurkale22 merged commit f0cfb96 into open-telemetry:master Nov 6, 2019
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
martinkuba pushed a commit to martinkuba/opentelemetry-js that referenced this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants