-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update metrics README #490
Merged
mayurkale22
merged 8 commits into
open-telemetry:master
from
mayurkale22:metrics_readme
Nov 27, 2019
Merged
chore: update metrics README #490
mayurkale22
merged 8 commits into
open-telemetry:master
from
mayurkale22:metrics_readme
Nov 27, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurkale22
requested review from
bg451,
danielkhan,
markwolff,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
November 5, 2019 23:42
draffensperger
approved these changes
Nov 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to add labels to these examples as well? (Maybe as a follow-up?)
Codecov Report
@@ Coverage Diff @@
## master #490 +/- ##
==========================================
+ Coverage 90.35% 92.28% +1.93%
==========================================
Files 149 152 +3
Lines 7534 7359 -175
Branches 663 649 -14
==========================================
- Hits 6807 6791 -16
+ Misses 727 568 -159
|
mayurkale22
force-pushed
the
metrics_readme
branch
from
November 25, 2019 18:21
d1160b2
to
d4784ad
Compare
@open-telemetry/javascript-approvers Please review |
dyladan
reviewed
Nov 25, 2019
dyladan
approved these changes
Nov 25, 2019
dyladan
requested changes
Nov 25, 2019
dyladan
approved these changes
Nov 25, 2019
xiao-lix
approved these changes
Nov 26, 2019
obecny
approved these changes
Nov 27, 2019
mayurkale22
force-pushed
the
metrics_readme
branch
from
November 27, 2019 16:45
566c835
to
7e9fcf6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?