deps(opentelemetry-instrumentation): Bump shimmer types to 1.2.0
#4854
Conversation
There was a problem hiding this comment.
I'll probably leave this to @pichlermarc to review, as he groks the TS requirements better. (However, he's on vacation for a while now, so I'm not sure if that delay causes a lot of hardship.)
There was a problem hiding this comment.
I think your PR accidentally re-added some git submodules that were removed a while back.
There was a problem hiding this comment.
That is correct 😂 I haven't felt this stupid in a long time, but how the hell do I get rid of those again.
There was a problem hiding this comment.
Voodoo? Git submodules are ... a pain. I have to go Googling everytime they come up.
I think this is the SO question I always land on: https://stackoverflow.com/questions/1260748/how-do-i-remove-a-submodule
I recall using the steps in what is now the "Older community wiki instructions:" section of the top answer there.
There was a problem hiding this comment.
I just rm -rfed the repo and opened a new PR. Sorry about the inconvenience: #4865
lforst
force-pushed
the
lforst-bump-shimmer-typedef
branch
2 times, most recently
from
a141888
to
cf7748f
Compare
|
Closed in favor of: #4865 |
Which problem is this PR solving?
Bumps the shimmer package to a version that doesn't include an invasive type that breaks certain setups.
See PR for more details: DefinitelyTyped/DefinitelyTyped#69966
Fixes getsentry/sentry-javascript#12682
This PR supersedes #4835
Short description of the changes
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I don't think tests are necessary here. Feel free to let me know though!
Checklist:
Unit tests have been addedDocumentation has been updated