Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add SimpleSpanProcessor warning #4798

Merged
merged 3 commits into from
Jun 18, 2024
Merged

docs: add SimpleSpanProcessor warning #4798

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c26b3e1
docs: add SimpleSpanProcessor warning
danstarns Jun 15, 2024
813df14
Update packages/opentelemetry-sdk-trace-base/src/export/SimpleSpanPro…
danstarns Jun 18, 2024
defcadc
Merge branch 'main' into docs/simple-span-note
pichlermarc Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/opentelemetry-sdk-trace-base/src/export/SimpleSpanProcessor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ import { Resource } from '@opentelemetry/resources';
* to {@link ReadableSpan} and passes it to the configured exporter.
*
* Only spans that are sampled are converted.
*
* NOTE: This {@link SpanProcessor} exports every ended span individually instead of batching spans together, which causes significant performance overhead with most exporters. For production use, please consider using the {@link BatchSpanProcessor} instead.
*/
export class SimpleSpanProcessor implements SpanProcessor {
private _shutdownOnce: BindOnceFuture<void>;
Expand Down