-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: regenerate recently-expired test TLS certs #4777
tests: regenerate recently-expired test TLS certs #4777
Conversation
Tests started failing yesterday because the various TLS certs in the repo used for TLS testing had expired $ openssl x509 -noout -enddate -in experimental/packages/exporter-logs-otlp-grpc/test/certs/ca.crt notAfter=Jun 7 16:44:23 2024 GMT This change regenerates all the TLS certs used for testing and examples/https. It also adds a test case in each relevant package that will fail with an obvious message when these certs expire next time (certs are generated with a 1y expiry). This also adds a comment 'npm run main:regenerate-test-certs' that can be used to run the maintenance task.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4777 +/- ##
=======================================
Coverage 91.04% 91.04%
=======================================
Files 89 89
Lines 1954 1954
Branches 416 416
=======================================
Hits 1779 1779
Misses 175 175 |
https://github.com/open-telemetry/opentelemetry-js/actions/runs/9424584277/job/25965060703 shows failing tests. A failure example is:
I flailed for a while before I noticed that the failure was for TLS only and because the local TLS certs for testing had expired. showing the expiry date of all the test certs
added test to explicitly check expiry of the test certsNow when these expire it will look like this:
and hopefully the reader will see the suggestion to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for taking care of that @trentm 🙂
testing that the certs are valid and the suggestion will be very helpful in the future. 👍
* tests: regenerate recently-expired test TLS certs Tests started failing yesterday because the various TLS certs in the repo used for TLS testing had expired $ openssl x509 -noout -enddate -in experimental/packages/exporter-logs-otlp-grpc/test/certs/ca.crt notAfter=Jun 7 16:44:23 2024 GMT This change regenerates all the TLS certs used for testing and examples/https. It also adds a test case in each relevant package that will fail with an obvious message when these certs expire next time (certs are generated with a 1y expiry). This also adds a comment 'npm run main:regenerate-test-certs' that can be used to run the maintenance task. * lint:fix, add changelog entry * skip cert expiry test on node v14, because crypto.X509Certificate came in node v15
Tests started failing yesterday because the various TLS certs in
the repo used for TLS testing had expired
This change regenerates all the TLS certs used for testing and
examples/https. It also adds a test case in each relevant package
that will fail with an obvious message when these certs expire
next time (certs are generated with a 1y expiry).
This also adds a comment 'npm run main:regenerate-test-certs'
that can be used to run the maintenance task.