fix(instr-fetch): do not enable in Node.js; clarify in docs this instr is for web fetch only #4498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r is for web fetch only
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4498 +/- ##
==========================================
- Coverage 92.43% 92.40% -0.03%
==========================================
Files 330 330
Lines 9525 9531 +6
Branches 2033 2036 +3
==========================================
+ Hits 8804 8807 +3
- Misses 721 724 +3
|
MSNev
approved these changes
Feb 21, 2024
|
There is this PR that is relevant: |
pichlermarc
approved these changes
Feb 22, 2024
david-luna
approved these changes
Feb 22, 2024
pichlermarc
approved these changes
Feb 23, 2024
This was referenced May 28, 2024
Open
Zirak
pushed a commit
to Zirak/opentelemetry-js
that referenced
this pull request
Sep 14, 2024
…r is for web fetch only (open-telemetry#4498) * fix(instr-fetch): do not enable in Node.js; clarify in docs this instr is for web fetch only * add a changelog entry * add a diagnostic warning if attempting to use instr-fetch in Node.js * fixup! add a diagnostic warning if attempting to use instr-fetch in Node.js --------- Co-authored-by: Marc Pichler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A side issue from #4496 was the mistaken use of instrumentation-fetch for Node.js's
fetch(). instrumentation-fetch does not intend to handle Node.js's fetch.This change makes it so instrumentation-fetch will noop when used in Node.js.
Refs: #4496
Theoretically I think instrumentation-fetch should be able instrument Node.js fetch, but currently it is written with dependencies on a web otel package and its tests assume web/browser. See #4333 for discussion on instrumenting Node.js'
fetch().