Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute binaries from root node modules #4302

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Nov 16, 2023

Fixes #4301

@dyladan dyladan requested a review from a team November 16, 2023 19:25
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #4302 (33d1559) into main (4eddf51) will decrease coverage by 0.77%.
The diff coverage is n/a.

❗ Current head 33d1559 differs from pull request most recent head bc7bd49. Consider uploading reports for the commit bc7bd49 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4302      +/-   ##
==========================================
- Coverage   92.31%   91.55%   -0.77%     
==========================================
  Files         330      323       -7     
  Lines        9424     8995     -429     
  Branches     1998     1916      -82     
==========================================
- Hits         8700     8235     -465     
- Misses        724      760      +36     

see 9 files with indirect coverage changes

@dyladan dyladan merged commit 51be418 into open-telemetry:main Nov 16, 2023
17 of 18 checks passed
@dyladan dyladan deleted the exec-root branch November 16, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean builds failing on main and next
2 participants