feat(plugin-dns): add lookup patches #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlivierAlbertini
force-pushed
the
feature/plugin-dns
branch
3 times, most recently
from
c3a61ad to
e255799
Compare
Codecov Report
@@ Coverage Diff @@
## master #424 +/- ##
==========================================
- Coverage 95.84% 95.37% -0.48%
==========================================
Files 108 118 +10
Lines 5315 5919 +604
Branches 431 500 +69
==========================================
+ Hits 5094 5645 +551
- Misses 221 274 +53
Continue to review full report at Codecov.
|
OlivierAlbertini
force-pushed
the
feature/plugin-dns
branch
5 times, most recently
from
4546635 to
43a07ff
Compare
ref: #423 add docs add example include promise patch for lookup Signed-off-by: Olivier Albertini <[email protected]>
OlivierAlbertini
force-pushed
the
feature/plugin-dns
branch
from
43a07ff to
8c39cde
Compare
OlivierAlbertini
requested review from
bg451,
danielkhan,
iredelmeier,
mayurkale22,
rochdev and
vmarchaud
as code owners
bg451
approved these changes
Oct 14, 2019
| ) => { | ||
| const { code, message, name } = err; | ||
| const attributes = { | ||
| [AttributeNames.DNS_ERROR_MESSAGE]: message, |
There was a problem hiding this comment.
is message a limited set of of possible values or unlimited (e.g. has some unique identifier in it or something)? If it's the latter it should probably go onto the span as an event
There was a problem hiding this comment.
I believe we have a limited set. I'm also not sure if people will use this tag for filtering (Pretty sure, they won't for Jaeger since you need to have an exact match). Perhaps we could create an another PR since we could change also http/https plugins as well if we want to create an event instead.
danielkhan
approved these changes
Oct 14, 2019
mayurkale22
reviewed
Oct 14, 2019
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
…y#424) Without this, spans created in the lambda function are not part of the same trace as the handler span. Co-authored-by: Valentin Marchaud <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes