Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(opencensus-shim): implement OpenCensus metric producer #4066

Merged
merged 15 commits into from
Sep 14, 2023
Merged
Show file tree
Hide file tree
Changes from 13 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions experimental/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ All notable changes to experimental packages in this project will be documented
### :rocket: (Enhancement)

* feat: update PeriodicExportingMetricReader and PrometheusExporter to accept optional metric producers [#4077](https://github.com/open-telemetry/opentelemetry-js/pull/4077) @aabmass
* feat(opencensus-shim): implement OpenCensus metric producer [#4066](https://github.com/open-telemetry/opentelemetry-js/pull/4066) @aabmass

### :bug: (Bug Fix)

Expand Down
2 changes: 2 additions & 0 deletions experimental/packages/shim-opencensus/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@
},
"dependencies": {
"@opentelemetry/core": "1.17.0",
"@opentelemetry/resources": "1.17.0",
"@opentelemetry/sdk-metrics": "1.17.0",
"require-in-the-middle": "^7.1.1",
"semver": "^7.5.2"
},
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,103 @@
/*
* Copyright The OpenTelemetry Authors
aabmass marked this conversation as resolved.
Show resolved Hide resolved
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

import * as oc from '@opencensus/core';
import { Resource } from '@opentelemetry/resources';
import {
CollectionResult,
MetricData,
MetricProducer,
ScopeMetrics,
} from '@opentelemetry/sdk-metrics';
import { mapOcMetric } from './metric-transform';
import { VERSION } from './version';

const SCOPE = {
name: '@opentelemetry/shim-opencensus',
version: VERSION,
} as const;

interface OpenCensusMetricProducerOptions {
/**
* An instance of OpenCensus MetricProducerManager. If not provided,
* `oc.Metrics.getMetricProducerManager()` will be used.
*/
openCensusMetricProducerManager?: oc.MetricProducerManager;
}

/**
* A {@link MetricProducer} which collects metrics from OpenCensus. Provide an instance to your
* {@link MetricReader} when you create it to include all OpenCensus metrics in the collection
* result:
*
* @example
* ```
* const meterProvider = new MeterProvider();
* const reader = new PeriodicExportingMetricReader({
* metricProducers: [new OpenCensusMetricProducer()],
* exporter: exporter,
* });
* meterProvider.addMetricReader(reader);
* ```
*/
export class OpenCensusMetricProducer implements MetricProducer {
private _openCensusMetricProducerManager: oc.MetricProducerManager;

constructor(options?: OpenCensusMetricProducerOptions) {
this._openCensusMetricProducerManager =
options?.openCensusMetricProducerManager ??
oc.Metrics.getMetricProducerManager();
}

async collect(): Promise<CollectionResult> {
const metrics = await this._collectOpenCensus();
const scopeMetrics: ScopeMetrics[] =
metrics.length === 0
? []
: [
{
scope: SCOPE,
metrics,
},
];

return {
errors: [],
resourceMetrics: {
// Resource is ignored by the SDK, it just uses the SDK's resource
resource: Resource.EMPTY,
scopeMetrics,
},
};
}

private async _collectOpenCensus(): Promise<MetricData[]> {
const metrics: MetricData[] = [];

// The use of oc.Metrics.getMetricProducerManager() was adapted from
// https://github.com/census-instrumentation/opencensus-node/blob/d46c8891b15783803d724b717db9a8c22cb73d6a/packages/opencensus-exporter-stackdriver/src/stackdriver-monitoring.ts#L122
for (const metricProducer of this._openCensusMetricProducerManager.getAllMetricProducer()) {
for (const metric of metricProducer.getMetrics()) {
const metricData = mapOcMetric(metric);
if (metricData !== null) {
metrics.push(metricData);
}
}
}

return metrics;
}
}
2 changes: 1 addition & 1 deletion experimental/packages/shim-opencensus/src/ShimSpan.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
import * as oc from '@opencensus/core';
import { ShimTracer } from './ShimTracer';
import { AttributeValue, Span, SpanStatusCode, diag } from '@opentelemetry/api';
import { mapMessageEvent, reverseMapSpanContext } from './transform';
import { mapMessageEvent, reverseMapSpanContext } from './trace-transform';

// Copied from
// https://github.com/census-instrumentation/opencensus-node/blob/v0.1.0/packages/opencensus-core/src/trace/model/span.ts#L61
Expand Down
2 changes: 1 addition & 1 deletion experimental/packages/shim-opencensus/src/ShimTracer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import {
Tracer,
} from '@opentelemetry/api';
import { DEFAULT_SPAN_NAME, ShimSpan } from './ShimSpan';
import { mapSpanContext, mapSpanKind } from './transform';
import { mapSpanContext, mapSpanKind } from './trace-transform';
import { shimPropagation } from './propagation';

// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
Expand Down
1 change: 1 addition & 0 deletions experimental/packages/shim-opencensus/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,5 @@
*/

export { ShimTracer } from './ShimTracer';
export { OpenCensusMetricProducer } from './OpenCensusMetricProducer';
export { installShim, uninstallShim } from './shim';
211 changes: 211 additions & 0 deletions experimental/packages/shim-opencensus/src/metric-transform.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,211 @@
/*
* Copyright The OpenTelemetry Authors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

import * as oc from '@opencensus/core';
import { Attributes, HrTime, ValueType, diag } from '@opentelemetry/api';
import {
AggregationTemporality,
DataPoint,
DataPointType,
GaugeMetricData,
HistogramMetricData,
InstrumentType,
MetricData,
SumMetricData,
} from '@opentelemetry/sdk-metrics';

type BaseMetric = Omit<MetricData, 'dataPoints' | 'dataPointType'>;
interface MappedType {
type: InstrumentType;
valueType: ValueType;
dataPointType:
| DataPointType.GAUGE
| DataPointType.SUM
| DataPointType.HISTOGRAM;
}
const ZEROED_HRTIME: HrTime = [0, 0];

export function mapOcMetric(metric: oc.Metric): MetricData | null {
const { description, name, unit, type } = metric.descriptor;
const mappedType = mapOcMetricDescriptorType(type);
if (mappedType === null) {
return null;
}

const baseMetric: BaseMetric = {
aggregationTemporality: AggregationTemporality.CUMULATIVE,
descriptor: {
description,
name,
unit,
type: mappedType.type,
valueType: mappedType.valueType,
},
};

switch (mappedType.dataPointType) {
case DataPointType.GAUGE:
return gauge(metric, mappedType.dataPointType, baseMetric);
case DataPointType.SUM:
return sum(metric, mappedType.dataPointType, baseMetric);
case DataPointType.HISTOGRAM:
return histogram(metric, mappedType.dataPointType, baseMetric);
}
}

function mapOcMetricDescriptorType(
type: oc.MetricDescriptorType
): MappedType | null {
switch (type) {
case oc.MetricDescriptorType.GAUGE_INT64:
return {
type: InstrumentType.OBSERVABLE_GAUGE,
aabmass marked this conversation as resolved.
Show resolved Hide resolved
valueType: ValueType.INT,
dataPointType: DataPointType.GAUGE,
};
case oc.MetricDescriptorType.GAUGE_DOUBLE:
return {
type: InstrumentType.OBSERVABLE_GAUGE,
valueType: ValueType.DOUBLE,
dataPointType: DataPointType.GAUGE,
};

case oc.MetricDescriptorType.CUMULATIVE_INT64:
return {
type: InstrumentType.COUNTER,
valueType: ValueType.INT,
dataPointType: DataPointType.SUM,
};
case oc.MetricDescriptorType.CUMULATIVE_DOUBLE:
return {
type: InstrumentType.COUNTER,
valueType: ValueType.DOUBLE,
dataPointType: DataPointType.SUM,
};

case oc.MetricDescriptorType.CUMULATIVE_DISTRIBUTION:
return {
type: InstrumentType.HISTOGRAM,
valueType: ValueType.DOUBLE,
dataPointType: DataPointType.HISTOGRAM,
};

case oc.MetricDescriptorType.SUMMARY:
aabmass marked this conversation as resolved.
Show resolved Hide resolved
case oc.MetricDescriptorType.GAUGE_DISTRIBUTION:
case oc.MetricDescriptorType.UNSPECIFIED:
diag.warn(
'Got unsupported metric MetricDescriptorType from OpenCensus: %s',
type
);
return null;
}
}

function gauge(
metric: oc.Metric,
dataPointType: DataPointType.GAUGE,
baseMetric: BaseMetric
): GaugeMetricData {
return {
...baseMetric,
dataPoints: dataPoints(metric, value => value as number),
dataPointType,
};
}

function sum(
metric: oc.Metric,
dataPointType: DataPointType.SUM,
baseMetric: BaseMetric
): SumMetricData {
return {
...baseMetric,
dataPoints: dataPoints(metric, value => value as number),
isMonotonic: true,
dataPointType,
};
}

function histogram(
metric: oc.Metric,
dataPointType: DataPointType.HISTOGRAM,
baseMetric: BaseMetric
): HistogramMetricData {
return {
...baseMetric,
dataPoints: dataPoints(metric, value => {
const {
bucketOptions: {
explicit: { bounds },
},
buckets,
count,
sum: distSum,
} = value as oc.DistributionValue;

return {
buckets: {
boundaries: bounds,
counts: buckets.map(bucket => bucket.count),
},
count,
sum: distSum,
};
}),
dataPointType,
};
}

function dataPoints<T>(
metric: oc.Metric,
valueMapper: (value: oc.TimeSeriesPoint['value']) => T
): DataPoint<T>[] {
return metric.timeseries.flatMap(ts => {
const attributes = zipOcLabels(metric.descriptor.labelKeys, ts.labelValues);

// use zeroed hrTime if it is undefined, which probably shouldn't happen
const startTime = ocTimestampToHrTime(ts.startTimestamp) ?? ZEROED_HRTIME;

// points should be an array with a single value, so this will return a single point per
// attribute set.
return ts.points.map(
aabmass marked this conversation as resolved.
Show resolved Hide resolved
(point): DataPoint<T> => ({
startTime,
attributes,
value: valueMapper(point.value),
endTime: ocTimestampToHrTime(point.timestamp) ?? ZEROED_HRTIME,
})
);
});
}

function ocTimestampToHrTime(ts: oc.Timestamp | undefined): HrTime | null {
if (ts === undefined || ts.seconds === null) {
return null;
}
return [ts.seconds, ts.nanos ?? 0];
}

function zipOcLabels(
labelKeys: oc.LabelKey[],
labelValues: oc.LabelValue[]
): Attributes {
const attributes: Attributes = {};
for (let i = 0; i < labelKeys.length; i++) {
attributes[labelKeys[i].key] = labelValues[i].value ?? '';
}
return attributes;
}
2 changes: 1 addition & 1 deletion experimental/packages/shim-opencensus/src/propagation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import {
TextMapGetter,
TextMapSetter,
} from '@opentelemetry/api';
import { mapSpanContext, reverseMapSpanContext } from './transform';
import { mapSpanContext, reverseMapSpanContext } from './trace-transform';

class Getter implements TextMapGetter<void> {
constructor(private ocGetter: oc.HeaderGetter) {}
Expand Down
Loading