feat(minification): Add noEmitHelpers, importHelpers and tslib as a dependency #3914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSNev
commented
Jun 14, 2023
experimental/packages/opentelemetry-instrumentation/src/platform/browser/index.ts
Show resolved
Hide resolved
MSNev
commented
Jun 14, 2023
experimental/packages/opentelemetry-instrumentation/test/node/EsmInstrumentation.test.mjs
Show resolved
Hide resolved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3914 +/- ##
=======================================
Coverage 92.89% 92.89%
=======================================
Files 297 297
Lines 8838 8838
Branches 1815 1815
=======================================
Hits 8210 8210
Misses 628 628 |
pichlermarc
approved these changes
Jun 16, 2023
There was a problem hiding this comment.
Looks good to me 🙂
Just wondering about the change in the esm instrumentation test. Maybe @JamieDanielson can shed some light on why this might be needed 🤔
experimental/packages/opentelemetry-instrumentation/test/node/EsmInstrumentation.test.mjs
Show resolved
Hide resolved
legendecas
reviewed
Jun 19, 2023
|
I like this change! Just a minor nit about the change. |
MSNev
force-pushed
the
MSNev/Minification
branch
from
8cefd1c to
1e0c4a0
Compare
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Jun 26, 2023
…ependency (open-telemetry#3914) * feat(minification): Add noEmitHelpers, importHelpers and tslib as a dependency * fix: Lint fixes * Remove noEmitHelpers as not needed --------- Co-authored-by: Chengzhong Wu <[email protected]>
dyladan
added a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Jul 19, 2023
…b as a dependency (open-telemetry#3914)" This reverts commit 74393ac.
dyladan
added a commit
that referenced
this pull request
Jul 21, 2023
This was referenced Nov 27, 2023
[Snyk] Security upgrade @opentelemetry/sdk-node from 0.40.0 to 0.41.2
sumodgeorge/opentelemetry-js#7
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
To better support minification of the generated code we need to change the default settings by adding the following to the tsconfg.base.json.
Fixes #3913
Short description of the changes
Adds
importHelpersandnoEmitHelperstotsconfig.base.jsonUpdates all
package.jsonto includetslibas a dependency with "^2.3.1" as this version is the first version that supported TypeScript 4.4, this should allow all v2.x versions oftslibto be used.Updates instrumentation test
EsmInstrumentation.test.mjsdue to failure to importInstrumentationBaseType of change
Please delete options that are not relevant.
This is not expected to be a code breaking change
How Has This Been Tested?
Compiled and built locally using
npm run compileandnpm testChecklist: