Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(otlp-grpc-exporter): update TLS certs and keys for tests #3878

Merged
merged 2 commits into from
Jun 8, 2023

Conversation

llc1123
Copy link
Contributor

@llc1123 llc1123 commented Jun 8, 2023

Which problem is this PR solving?

The tests are failing because of expired certs.

Short description of the changes

Updated the certs and keys.

Also remove unused certs in other tests.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Existing tests

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added

@llc1123 llc1123 requested a review from a team June 8, 2023 16:54
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #3878 (57d5847) into main (51dd6f2) will increase coverage by 0.76%.
The diff coverage is n/a.

❗ Current head 57d5847 differs from pull request most recent head 6e0dc59. Consider uploading reports for the commit 6e0dc59 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3878      +/-   ##
==========================================
+ Coverage   92.20%   92.97%   +0.76%     
==========================================
  Files         145      300     +155     
  Lines        3452     9104    +5652     
  Branches      711     1862    +1151     
==========================================
+ Hits         3183     8464    +5281     
- Misses        269      640     +371     

see 171 files with indirect coverage changes

@dyladan dyladan merged commit 228e67b into open-telemetry:main Jun 8, 2023
@llc1123 llc1123 deleted the chore/update-certs branch June 12, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants